test: add weekly date index test and extract _check_value() helper - #219
Merged
Conversation
- Add test_weekly_date_index with weekly-spaced dates starting 2026-01-01 - Extract _check_value() helper in conftest.py to deduplicate start/end comparison logic - Update conftest.py docstring to mention numeric types (int, float) - Remove unused import math from conftest.py
github-actions
Bot
requested review from
ChrisMarsden833
and removed request for
RussellSB
July 9, 2026 06:42
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ChrisMarsden833
approved these changes
Jul 25, 2026
Collaborator
|
/oc can you resolve conflicts? |
…nftest # Conflicts: # tests/conftest.py
Contributor
|
Conflict resolved. The issue was that |
Collaborator
|
/oc Tests do now pass, good job, but there are several warnings generated, which all seem to be derivative of DeprecationWarning: 'is_abrupt_padded' in method_params is deprecated. Can you create a new branch and PR into nodates to resolve this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds test coverage and improves test infrastructure:
All tests pass after these changes.